feedback-manager: Track DBus clients and end feedbacks if they go away
When the client goes away we build up a list of events to end feedback for to make sure the hash table isn't modified in place. tThe alternative approach would be to disconnect the...
View Articlefbd-dev-leds: Use automatic deep cleanup for device list
The current logic was fragile and failed e.g. when the FEEDBACKD_UDEV_VAL_LED would not match leaking the dev since the g_object_unref() at the end of the loop was never hit. Prevent that with...
View Articlefbd-dev-sound: Use correct cleanup for hash table
This went unnoticed since the manager forgot to cleanup this at all (see follow up commit).
View Articlefbd-feedback-manager: Make sure theme path components are '/' separated
Previously, assembly of the theme paths for custom paths (based on `XDG_DATA_DIRS`) was performed using `g_strconcat`, which produced erroneous file paths with missing path separators due to a typo in...
View ArticleREADME: Add explanation on custom theme paths
The README currently states that feedbackd uses the `default.json` theme, whose location is hardcoded into the application. This doesn't reflect the current state of the code. Explain the ability to...
View ArticleClik here to view.
feedback-manager: Search for default theme under XDG_CONFIG_HOME first
This would allow users to create their own feedback profiles without editing system files or using root privileges Signed-off-by: Pablo Correa Gómez<ablocorrea@hotmail.com>
View Articlefbd-dev-sound: Honour sound theme name for all GNOME based desktops
Phosh recently changed to XDG_CURRENT_DESKTOP=GNOME:Phosh and has since stopped using the configured theme and instead used the fallback freedesktop theme. Closes #41
View Articled/control: Add json-glib-tools as build dependency
This will make sure that the json theme file gets validated in CI.
View Articlefeedback-theme: Add phone-hangup event
Named after the corresponding notification from the sound naming spec: http://0pointer.de/public/sound-naming-spec.html
View Articlefeedback-theme: Add phone-failure event
Named after the corresponding notification from the sound naming spec: http://0pointer.de/public/sound-naming-spec.html
View Articlefeedback-theme: Add phone-outgoing-busy event
Named after the corresponding notification from the sound naming spec: http://0pointer.de/public/sound-naming-spec.html
View Articlefbd-dev-sounce: Name data consistently
We name it `data` elsewhere. Don't call it `object` in one function.
View Articlefbd-dev-sound: Delay sending `ended` signal
Remove the feedback and the associated callback data before invoking the callback (which then triggers FbdFeebackBased:ended) since we otherwise remove the data from the currently playing sound from...
View Articlegitlab-ci: Switch to bullseye
Drop support for buster, this can be handled in downstream builds.
View Articled/changelog: Bump changes line to a recent date too
It was still stuck at 2021-10-07. Fixup version too while at that.
View ArticleReload theme on SIGHUP signal
Fixes #28 Allows for users/applications to request a theme reload by sending SIGHUP signal to the daemon.
View Article
